Add support for PEP 735 dependency-groups #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
|
While we are at it, we should sort the keys inside this table alphabetically. |
browniebroke
force-pushed
the
feat/dependency-groups
branch
2 times, most recently
from
9a422e3
to
36b0a0f
Compare
browniebroke
commented
Oct 26, 2024
Signed-off-by: Bernát Gábor <[email protected]>
Signed-off-by: Bernát Gábor <[email protected]>
gaborbernat
force-pushed
the
feat/dependency-groups
branch
2 times, most recently
from
1605f2d
to
c285f42
Compare
|
Ok, looks alright now. Thanks for the contribution, well done for your first PR. |
Signed-off-by: Bernát Gábor <[email protected]>
gaborbernat
force-pushed
the
feat/dependency-groups
branch
from
c285f42
to
a748cba
Compare
|
Thanks for getting it over the line! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency groups (PEP 735) has just landed in uv and got exclited to try it out on one of my projects, but noticed that the group ended up lost in the middle of the linters table. Putting it right after the
projecttable seems like the most obvious place...That seems to do the trick, but let me know if I missed anything (it's my first PR in 🦀)