Feature/#21: Remove disparity between the partial inference exercise and solution #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #21.
Firstly, thanks for creating this fantastic TypeScript content. I noticed this disparity between the exercise and the solution when working through the exercise; it didn't seem to be mentioned in the solution video, and I stumbled across a pre-existing issue (#21) so I've raised this pull request to address it.
This pull request removes the default type argument from the selectors generic in the partial inference workshop. The default widens the type of the generic to
any
which could trip people up (and arguably/evidently has).If this was intentionally left in place to manipulate the compiler errors to better make an example of the partial inference problem, then perhaps this issue can be closed, and the default argument mentioned/explained in the problem video and solution?
Thanks again for the amazing content as always Matt!
Changes