Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#21: Remove disparity between the partial inference exercise and solution #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

louis-young
Copy link

PR for #21.

Firstly, thanks for creating this fantastic TypeScript content. I noticed this disparity between the exercise and the solution when working through the exercise; it didn't seem to be mentioned in the solution video, and I stumbled across a pre-existing issue (#21) so I've raised this pull request to address it.

This pull request removes the default type argument from the selectors generic in the partial inference workshop. The default widens the type of the generic to any which could trip people up (and arguably/evidently has).

If this was intentionally left in place to manipulate the compiler errors to better make an example of the partial inference problem, then perhaps this issue can be closed, and the default argument mentioned/explained in the problem video and solution?

Thanks again for the amazing content as always Matt!

Changes

  • Remove the default type argument from the selectors generic.

@louis-young louis-young changed the title Feature/#21: Remove the default type argument from the selectors generic Feature/#21: Remove disparity between the partial inference exercise and solution May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant