Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

one suggestion #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

one suggestion #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 2 additions & 18 deletions book-content/chapters/15-designing-your-types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,25 +81,9 @@ type Example = ResourceStatus<{

Just like with `Pick` and `Omit`, the type argument is passed in as an argument to the generic type.

But what type will `Example` be?
We set the result of `ResourceStatus` to be `unknown` above, so let's actually implement out type.

```tsx
// hovering over Example shows
type Example = unknown;
```

We set the result of `ResourceStatus` to be `unknown`. Why is this happening? We can get a clue by hovering over the `TContent` parameter in the `ResourceStatus` type:

```tsx
type ResourceStatus<TContent> = unknown;

// hovering over TContent shows:
// Type 'TContent' is declared but its value is never read.
```

We're not _using_ the `TContent` parameter. We're just returning `unknown`, no matter what is passed in. So, the `Example` type is also `unknown`.

So, let's use it. Let's update the `ResourceStatus` type to match the structure of the `StreamingPlaylist` and `StreamingAlbum` types, with the bit we want to be dynamic replaced with the `TContent` type parameter:
Let's update the `ResourceStatus` type to match the structure of the `StreamingPlaylist` and `StreamingAlbum` types, with the bit we want to be dynamic replaced with the `TContent` type parameter:

```tsx
type ResourceStatus<TContent> =
Expand Down