Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isEmpty): isEmpty should return true for objects with only enumerable symbol properties #791

Merged
merged 4 commits into from
Nov 9, 2024

Conversation

mass2527
Copy link
Contributor

@mass2527 mass2527 commented Nov 4, 2024

Lodash's isEmpty function checks only the enumerable own string properties of an object. It uses for...in to iterate over enumerable own and inherited properties and hasOwnProperty to filter for enumerable own properties. This behavior applies whether the value is a prototype or not.

Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 2:05pm

Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.08%. Comparing base (6d4fe72) to head (ae94971).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
+ Coverage   99.04%   99.08%   +0.03%     
==========================================
  Files         305      305              
  Lines        2727     2726       -1     
  Branches      802      800       -2     
==========================================
  Hits         2701     2701              
+ Misses         25       24       -1     
  Partials        1        1              

@raon0211 raon0211 merged commit b4cd255 into toss:main Nov 9, 2024
8 checks passed
@mass2527 mass2527 deleted the fix/isEmpty branch November 11, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants