Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hasbatchim 함수의 조건문 검사 로직을 개선합니다. #279

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

iamhungry1030
Copy link
Contributor

@iamhungry1030 iamhungry1030 commented Nov 11, 2024

Overview

다음과 같은 개선을 하였습니다.

  • charCode가 한글인지를 AND로 개선하던 로직을 OR로 개선하여, 앞의 조건이 true 일 경우 뒤의 조건을 검사하지 않도록 하였습니다.
  • options.only로 분기하던 if문을 switch case문으로 수정하여, options.only를 한 번의 분기만 하도록 수정하였습니다.

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

changeset-bot bot commented Nov 11, 2024

🦋 Changeset detected

Latest commit: d5dab6f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 9:15am

@iamhungry1030 iamhungry1030 changed the title hasbatchim 함수의 조건문 검사 로직을 개선합니다. chore: hasbatchim 함수의 조건문 검사 로직을 개선합니다. Nov 11, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.53%. Comparing base (a49eeca) to head (70d35ff).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files          38       38           
  Lines         639      642    +3     
  Branches      154      156    +2     
=======================================
+ Hits          636      639    +3     
  Misses          3        3           

Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!

@okinawaa okinawaa merged commit 0a60a65 into toss:main Nov 13, 2024
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants