-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: susa 함수에 jsdoc을 추가합니다. #250
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"es-hangul": patch | ||
--- | ||
|
||
docs: susa 함수에 jsdoc을 추가합니다. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BO-LIKE-CHICKEN 안녕하세요, 고민되는 지점이 있어서 멘션드리게 되었어요
제가 수사랑 수관형사가 뭔지 잘 몰라서, 결국 수사가 뭔지 수관형사가 무엇인지 검색해볼 것 같다는 생각이 들더라구요
@see 수사? https://ko.dict.naver.com/#/entry/koko/d0ce2b674cae4b44b9028f648dd458b0
이런 링크도 첨부하는 것이 좋을지 고민됩니다!
cc @okinawaa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
링크를 제공해주는 것은 너무 좋은 친절함 같지만, 링크를 전달하는 방식에서 이런 아이디어를 제안드려요 🙇🏻♂️
이렇게 제공하게되면 어려운 한글 도메인에 대한 설명 뿐만 아니라 의문을 가질 수 있는 함수의 제한(왜 1~100 까지만 지원하지?)에 대해서도 설명해 줄 수 있을 것 같아요 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
감사합니다 !!! 너무 좋네요!!! 🙇