Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: v2 migration 가이드를 작성합니다. #231

Merged
merged 3 commits into from
Aug 9, 2024
Merged

docs: v2 migration 가이드를 작성합니다. #231

merged 3 commits into from
Aug 9, 2024

Conversation

okinawaa
Copy link
Member

@okinawaa okinawaa commented Aug 9, 2024

Overview

fix #227

라이브러리 사용자들이, v2로 마이그레이션을 보다 쉽게 진행할 수 있도록 가이드를 작성합니다.

한국 영문
image
image

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

@okinawaa okinawaa requested a review from raon0211 as a code owner August 9, 2024 15:23
Copy link

changeset-bot bot commented Aug 9, 2024

⚠️ No Changeset found

Latest commit: 7f39b98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 4:20pm

@okinawaa
Copy link
Member Author

okinawaa commented Aug 9, 2024

번역중입니다

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.83%. Comparing base (0633b9f) to head (7f39b98).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files          31       31           
  Lines         600      600           
  Branches      145      145           
=======================================
  Hits          599      599           
  Misses          1        1           

Copy link
Member

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미 v2가 나간 상황에 중요한 추가라고 생각해서 여기서 리뷰보다는 점진적으로 수정하면 좋을 거 같아요. 빠르게 배포내보내면 좋을 것 같습니다👍

@okinawaa okinawaa merged commit 90c9cd8 into main Aug 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: v2로 마이그레이션하기 문서 작성하기
3 participants