Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: combineCharacter, combineVowels 에 대한 문서화를 진행합니다 #229

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

okinawaa
Copy link
Member

@okinawaa okinawaa commented Aug 9, 2024

Overview

fix #58

  1. combineCharacter에 대한 문서화를 진행합니다
    2.combineVowels에 대한 문서화를 진행합니다

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

@okinawaa okinawaa requested a review from raon0211 as a code owner August 9, 2024 13:51
Copy link

changeset-bot bot commented Aug 9, 2024

⚠️ No Changeset found

Latest commit: 86c3ab5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 2:53pm

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.83%. Comparing base (2c3c981) to head (86c3ab5).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files          31       31           
  Lines         600      600           
  Branches      145      145           
=======================================
  Hits          599      599           
  Misses          1        1           

@okinawaa okinawaa requested a review from manudeli August 9, 2024 14:06
Copy link
Member

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀🦅

docs/src/pages/docs/api/combine.ko.mdx Outdated Show resolved Hide resolved
docs/src/pages/docs/api/combine.en.mdx Outdated Show resolved Hide resolved
Comment on lines +57 to +71
### 사용해보기

<br />

<Sandpack>

```ts index.ts
import { combineVowels } from 'es-hangul';

console.log(combineVowels('ㅗ', 'ㅏ'))
console.log(combineVowels('ㅗ', 'ㅐ'))
console.log(combineVowels('ㅗ', 'ㅛ'))

```
</Sandpack>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kangju2000 최고에요👍

docs/src/pages/docs/api/combine.ko.mdx Outdated Show resolved Hide resolved
Copy link
Member

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

먼저 빠르게 배포합시다

@okinawaa okinawaa merged commit 32fc3f0 into main Aug 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: 공식 문서 최신화
3 participants