-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix]: 초성, 중성, 종성을 사용하도록 통일 #219
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cf4601f
fix: 초성, 중성, 종성을 사용하도록 통일
Collection50 059d1e4
fix: 표기 수정
Collection50 19664cd
fix: 표기 수정
Collection50 8308a61
fix: 표기 수정
Collection50 39a8810
fix: v2 반영
Collection50 66b7c8f
fix: conflict 해결
Collection50 953cbe5
fix: 불필요한 파일 삭제
Collection50 c4623f1
fix: import 수정
Collection50 b55a5f0
fix: 테스트 코드 수정
Collection50 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import { disassembleCompleteCharacter } from './disassembleCompleteCharacter'; | ||
|
||
describe('disassembleCompleteCharacter', () => { | ||
it('값', () => { | ||
expect(disassembleCompleteCharacter('값')).toEqual({ | ||
choseong: 'ㄱ', | ||
jungseong: 'ㅏ', | ||
jongseong: 'ㅂㅅ', | ||
}); | ||
}); | ||
|
||
it('리', () => { | ||
expect(disassembleCompleteCharacter('리')).toEqual({ | ||
choseong: 'ㄹ', | ||
jungseong: 'ㅣ', | ||
jongseong: '', | ||
}); | ||
}); | ||
|
||
it('빚', () => { | ||
expect(disassembleCompleteCharacter('빚')).toEqual({ | ||
choseong: 'ㅂ', | ||
jungseong: 'ㅣ', | ||
jongseong: 'ㅈ', | ||
}); | ||
}); | ||
|
||
it('박', () => { | ||
expect(disassembleCompleteCharacter('박')).toEqual({ | ||
choseong: 'ㅂ', | ||
jungseong: 'ㅏ', | ||
jongseong: 'ㄱ', | ||
}); | ||
}); | ||
|
||
it('완전한 한글 문자열이 아니면 undefined를 반환해야 합니다.', () => { | ||
expect(disassembleCompleteCharacter('ㄱ')).toBeUndefined; | ||
expect(disassembleCompleteCharacter('ㅏ')).toBeUndefined; | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
import { Syllable } from './rules.types'; | ||
|
||
export function replace받침ㅎ(currentSyllable: Syllable): Syllable['last'] { | ||
return currentSyllable.last.replace('ㅎ', '') as Syllable['last']; | ||
export function replace받침ㅎ(currentSyllable: Syllable): Syllable['jongseong'] { | ||
return currentSyllable.jongseong.replace('ㅎ', '') as Syllable['jongseong']; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
변수명이 변함에 따라 명확해져서 오해의 소지가 없어진 것 같아서 초성 중성 종성 주석은 제거되어도 될 것 같아요!