Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/vtx: fixing e2e tests #409

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Feat/vtx: fixing e2e tests #409

wants to merge 4 commits into from

Conversation

sidharthWeb3auth
Copy link
Contributor

@sidharthWeb3auth sidharthWeb3auth commented Oct 28, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Sidharth Suresh and others added 2 commits October 27, 2022 12:59
@sidharthWeb3auth sidharthWeb3auth marked this pull request as ready for review October 28, 2022 04:34
@@ -216,7 +234,7 @@ test.skip("Transfer page using imported account", async () => {
await page.click("button >> text=Cancel");
});

test("Transaction should happen correctly", async () => {
test.only("Transaction should happen correctly", async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should remove only

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually the entire tests for Transfer page using imported account is skipped at line 206.

// entering valid amount
});

test.skip("Check if total cost is displayed before confirming", async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skip?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants