Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set all FE engineers as owners of Picasso #4616

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

denieler
Copy link
Collaborator

Description

Setting all fe engineers as owners of the repo.

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@denieler denieler self-assigned this Oct 31, 2024
Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: 5663d5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pudek357 pudek357 requested a review from a team October 31, 2024 09:16
@sashuk
Copy link
Contributor

sashuk commented Oct 31, 2024

I think we also need to disable https://github.com/toptal/picasso/actions/runs/11609090571/workflow?pr=4616 workflow

Update: done in #4617

@denieler denieler merged commit 8dcf27a into master Oct 31, 2024
18 of 21 checks passed
@denieler denieler deleted the set-fe-eng-as-owners branch October 31, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants