-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support CodeBlock
#3790
feat: support CodeBlock
#3790
Conversation
🦋 Changeset detectedLatest commit: 8fdc11f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@toptal-anvil ping reviewers |
6ec5a99
to
0d5fb32
Compare
@toptal-anvil ping reviewers |
Do you think the output could be cleaned up a bit so it does not have those extra picasso/packages/picasso-rich-text-editor/src/LexicalEditor/utils/cleanup-html-output.ts Line 12 in db1887d
NIT: What do you think about adding a code black example to story (although it is already tracked in visual tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally (temploy returns 500 error):
- copying and pasting from
RichText
line-by-line and as a whole - toggling formatting for code blocks
- copying and pasting code blocks into each other, copying between editors, copying and pasting other types of rich text into code blocks and vice-versa
Tested locally. When only the empty lines are present in the editor, it lacks the margin that is there otherwise. deepin-screen-recorder_Select.area_20230810122849.mp4Also there's one thing that I'm not sure we should fix, but you can't really select existing part of the text and turn it into code block, it creates a block up until the existing node / paragraph boundary deepin-screen-recorder_Select.area_20230810123256.mp4 |
@mkrl The second issue is the same as we had with headings, it is still one paragraph as there is just I was actually trying even to convert just selected text, but it is pretty complex with a lot of edge cases. There is no specific requirement for this behaviour and I realized that there is not much benefit and it would be inconsistent with headings |
50179de
to
8fdc11f
Compare
@toptal-anvil ping reviewers |
thank you guys for finding these bugs 🙇, I addressed them all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments were addressed, thank you Tomas for such enormous work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tremendous work, thank you!
FX-4184
Description
The result of merging all separate PRs
How to test
Screenshots
Development checks
props
in component with documentationexamples
for componentBreaking change
PR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?