[FX-NULL] Restore number input behaviour and look (#4619)

toptal · Nov 6, 2024 · 1cafabe · 1cafabe
1 parent 8dcf27a
commit 1cafabe
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/.changeset/fast-shirts-greet.md b/.changeset/fast-shirts-greet.md
@@ -0,0 +1,7 @@
+---
+'@toptal/picasso-number-input': patch
+---
+
+### NumberInput
+
+- do not pass min and max to HTML number input
diff --git a/packages/base/NumberInput/src/NumberInput/NumberInput.tsx b/packages/base/NumberInput/src/NumberInput/NumberInput.tsx
@@ -97,8 +97,6 @@ export const NumberInput = forwardRef<HTMLInputElement, Props>(
         inputProps={{
           ...rest,
           step,
-          min,
-          max,
           // TODO: [FX-6102] Add test for wheel event
           onWheel: enableChangeOnMouseWheel
             ? undefined

diff --git a/packages/base/NumberInput/src/NumberInput/__snapshots__/test.tsx.snap b/packages/base/NumberInput/src/NumberInput/__snapshots__/test.tsx.snap
@@ -10,8 +10,6 @@ exports[`NumberInput renders 1`] = `
     <input
       aria-invalid="false"
       class="base-Input [&::-webkit-calendar-picker-indicator]:bg bg-transparent border-none box-border cursor-[inherit] h-full outline-none p-0 peer resize-none w-full text-md leading-4 text-black [&::placeholder]:text-gray [&::placeholder]:opacity-100 [&::-webkit-outer-spin-button]:appearance [&::-webkit-outer-spin-button]:m [&::-webkit-inner-spin-button]:appearance [&::-webkit-inner-spin-button]:m [-moz"
-      max="100"
-      min="-100"
       step="5"
       type="number"
       value="10"

diff --git a/packages/base/NumberInput/src/NumberInput/test.tsx b/packages/base/NumberInput/src/NumberInput/test.tsx
@@ -42,7 +42,7 @@ describe('NumberInput', () => {
     expect(container.firstChild).toMatchSnapshot()
   })
 
-  it('increase value', async () => {
+  it('increases value by step', async () => {
     const { getByDisplayValue, queryAllByRole } = renderNumberInput()
 
     const input = getByDisplayValue('10') as HTMLInputElement
@@ -55,7 +55,7 @@ describe('NumberInput', () => {
     expect(input.value).toBe('15')
   })
 
-  it('decrease value', () => {
+  it('decreases value by step', () => {
     const { getByDisplayValue, queryAllByRole } = renderNumberInput()
 
     const input = getByDisplayValue('10') as HTMLInputElement