Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dtb command from magiskboot #8385

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yujincheng08
Copy link
Collaborator

They are no longer useful.

Copy link
Collaborator

@vvb2060 vvb2060 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after #8337, #4788 dtb patch is no longer needed

@@ -195,18 +195,6 @@ rm -f ramdisk.cpio.orig config *.xz
# Binary Patches
#################

for dt in dtb kernel_dtb extra; do
if [ -f $dt ]; then
if ! ./magiskboot dtb $dt test; then
Copy link
Collaborator

@vvb2060 vvb2060 Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test should be safe to remove after 2 years. I believe affected users (if any) will restore the original boot after bootloop and try again.

@topjohnwu topjohnwu added the next Planned for the release *after* the next release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next Planned for the release *after* the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants