Move event triggers to after the connection timer is reset #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
We’re seeing a bad behaviour and we need your help to pinpoint the issue. The symptom is the following:
Notes:
All of this leads me to believe that the issue might be related to a bad clean up/reset of the connection timer, and investigating the code, I found several places where we actually trigger the disconnection events before we reset it (see the changes in this PR). So I wonder if it might get triggered and interrupt the newly started connection before being reset.
Also, I see that when initializing the timer, we don't reset its state here, but I couldn't fully track if this is called when we initialize the connection flow. I think it's called only during the static initialization flow, so this might not be related to the issue 🤔.