Feat: cleanup ig resources #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updates to resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When the clusters/igs are deleted, we must also clean up the resources that reference those objects like security groups. SGs have a list of referenced infrastructure resources which the reconciliation loop needs to ensure is up to date with the actual existing resources.
Solution
During the reconciliation loop, our provider checks the existence of every resource referenced by the SG. The resources that doesn't exist anymore are removed from the list and if by the end of this process there are no more resources being referenced, the SG is deleted. These changes also covers the use case when we just want to delete the SG keeping the machine pools referenced.