update binutils to 2.41 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
binutils-2.41
branch
3 times, most recently
from
8e1864c
to
0ca9013
Compare
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
binutils-2.41
branch
from
0ca9013
to
19fe5ec
Compare
This was referenced Oct 18, 2023
crazy-max
commented
Oct 18, 2023
| ARG LIBTAPI_VERSION=1100.0.11 | ||
| ARG CCTOOLS_VERSION=949.0.1-ld64-530 | ||
| ARG SIGTOOL_VERSION=1dafd2ca4651210ba9acce10d279ace22b50fb01 | ||
| # BINUTILS_PATCHES_VERSION defines version of aports to use for patches | ||
| ARG BINUTILS_PATCHES_VERSION=3.16-stable | ||
| ARG BINUTILS_VERSION=2.38 | ||
| ARG BINUTILS_PATCHES_VERSION=master |
There was a problem hiding this comment.
using master because patches for binutils 2.41 are only on Alpine edge repo.
There was a problem hiding this comment.
can we use the https://github.com/alpinelinux/aports/releases/tag/v20230901 tag
There was a problem hiding this comment.
yes this tag looks good, I'll open a follow-up to pin to it.
tonistiigi
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #121
try a recent version of binutils to check if it fixes segfault when building against riscv64. More info moby/buildkit#4316
edit: looks to fix our issue moby/buildkit#4348