(GTK/NCURSES): Better error dialog for network interfaces

tomac · Aug 24, 2017 · 82b5a99 · 82b5a99
1 parent edbf839
commit 82b5a99
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/gtk-callbacks.c b/src/gtk-callbacks.c
@@ -472,7 +472,11 @@ void gtk_c_attackparams_ok_click( GtkWidget *button, gpointer userdata )
 
     if ( attack_filter_all_params( params_ctx->params_list, params_ctx->nparams, &field ) < 0 )
     {
-        gtk_i_modaldialog( GTK_MESSAGE_ERROR, "Attack parameters", "Bad data on field '%s'!!", params_ctx->helper->attack_def->param[field].desc );
+        if ( params_ctx->helper->attack_def->param[field].type == FIELD_ENABLED_IFACE )
+            gtk_i_modaldialog( GTK_MESSAGE_ERROR, "Attack parameters", "Nonexistant or disabled network interface on field '%s'!!\n\nHave you enabled that interface?",
+                               params_ctx->helper->attack_def->param[field].desc );
+        else
+            gtk_i_modaldialog( GTK_MESSAGE_ERROR, "Attack parameters", "Bad data on field '%s'!!", params_ctx->helper->attack_def->param[field].desc );
     }
     else
     {

diff --git a/src/ncurses-interface.c b/src/ncurses-interface.c
@@ -465,9 +465,10 @@ void ncurses_i_attack_screen( struct term_node *node, u_int8_t mode, WINDOW *att
                      ret = attack_filter_all_params( attack_param, attack_def[j].nparams, &field );
                      if ( ret == -1) /* Error on data...*/
                      {
-                        ncurses_i_error_window(1,
-                              "Bad data on field '%s'!!",
-                              attack_param[field].desc);
+                        if ( attack_param[field].type == FIELD_ENABLED_IFACE )
+                            ncurses_i_error_window( 1, "Nonexistant or disabled network interface on field '%s'!!", attack_param[field].desc );
+                        else
+                            ncurses_i_error_window( 1, "Bad data on field '%s'!!", attack_param[field].desc );
                      }
                   } while(ret==-1);