Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use node.js 20.18.0 #780

Merged
merged 3 commits into from
Oct 20, 2024
Merged

use node.js 20.18.0 #780

merged 3 commits into from
Oct 20, 2024

Conversation

joshka
Copy link
Contributor

@joshka joshka commented Oct 18, 2024

This is the current LTS version which is recommended for prod usage.

Updates the netlify config and adds a mise.toml config file to configure
the node.js version to use when running the site locally.

This will fix the problem running next.js in #778

This is the current LTS version which is recommended for prod usage.

Updates the netlify config and adds a mise.toml config file to configure
the node.js version to use when running the site locally.
Copy link
Member

@mox692 mox692 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Regarding the version bump, I confirmed locally that there is no issue.

.mise.toml Outdated Show resolved Hide resolved
Copy link
Member

@mox692 mox692 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update the ci settings? Otherwise lgtm.

node-version: "18"

@joshka
Copy link
Contributor Author

joshka commented Oct 20, 2024

Can we also update the ci settings? Otherwise lgtm.

node-version: "18"

done

@mox692 mox692 merged commit bde7fa7 into tokio-rs:master Oct 20, 2024
7 checks passed
@joshka joshka deleted the jm/update-node branch October 20, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants