Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make redis integer frame signed #756

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cjshearer
Copy link

The documentation for the Frame enum in framing.md claims the Redis protocol frame for an integer is unsigned, which doesn't match the protocol spec: https://redis.io/docs/reference/protocol-spec/#integers

This type is a CRLF-terminated string that represents a signed, base-10, 64-bit integer.

see also tokio-rs/mini-redis#128

The documentation for the Frame enum in framing.md claims the Redis protocol frame for an integer is unsigned, which doesn't match the protocol spec: https://redis.io/docs/reference/protocol-spec/#integers

> This type is a CRLF-terminated string that represents a **signed**, base-10, 64-bit integer.

see also tokio-rs/mini-redis#128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant