Add fs::symlink function
#308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This LGTM (cc @Noah-Kennedy) |
Noah-Kennedy
approved these changes
Aug 2, 2024
|
@daniel-levin I've merged your change regardless of CI, as those failures are unrelated to this change and need to be fixed independently of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there! I am a happy user of tokio and I am quite excited about what io_uring can bring to the space.
This change adds the
symlinkfunction to tokio-uring, with the identical signature and documentation as in tokio itself. I added one unit test. I'm merrily doing blocking I/O inside the async block in the unit test, which I think should be fine because it's just a test.