Fix for non-square DDS textures #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing tons of GL warnings thrown into Chrome console due to getting fractional width / height when texture wasn't square.
|
I just ran into this problem and came here to post effectively the same patch 👍 |
|
A similar fix needs to be implemented inside crn.cpp for crn_get_uncompressed_size and crn_decompress, which of course then needs to be recompiled into crn_decomp.js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-square DDS textures were throwing GL warnings in Chrome console due to having fractional width / height for some mipmap levels.
This fix limits mipmap width / height sizes to a minimum of 1.