[AssemblyScript] porting source from JS to AS #421

StEvUgnIn · 2021-03-27T12:21:56Z

Follows #420

StEvUgnIn · 2021-03-27T12:30:56Z

Final steps are:

Fix typings between JS and AS/TS
Be able to work fully with emitted JS from AS implementation
Write an encapsulated interface layer for using WASM from any web programming environment
Port Mocha to AS/TS spec (as-pect)
Benchmark performances between JS and AS modes

Please comment here if you are interested to generously help. ⚡✨🚀

--
Documentation
https://mochajs.org/
https://tenner-joshua.gitbook.io/as-pect/

trusktr · 2021-03-28T16:14:08Z

This will be neat for AS users to have!

Is there a particular reason to commit the build artefacts to the repo? Those can be built during publish time when publishing to NPM for example.

Why build Wasm modules?

If people will import the JS code into their JS projects, or import the AS code into their AS projects, then the module builds would not be needed. The Wasm modules are needed only for JS users who would import the Wasm modules instead of the JS code.

Wondering if that's it's worth building modules. Would the barrier between JS and Wasm allow this to be faster?

It would be sweet to see what perf diff looks like in a JS example that makes many calls into the module, vs plain JS and vs plain AS.

StEvUgnIn · 2021-03-28T16:47:20Z

Hi @trusktr

This will be neat for AS users to have!

Thanks! I hope we could see more WebGL frameworks emerge on the WebAssembly platform and this helps to train programming in Assemblyscript 🙂

Is there a particular reason to commit the build artefacts to the repo? Those can be built during publish time when publishing to NPM for example.

I was unsure at first, but I decided to include this because of the AssemblyScript conventions and I suppose someone could just download the file to include it in an existing project, especially during this testing phase.

Why build Wasm modules?

If people will import the JS code into their JS projects, or import the AS code into their AS projects, then the module builds would not be needed. The Wasm modules are needed only for JS users who would import the Wasm modules instead of the JS code.

Yes, exactly.

A default .gitignore lies in the build repository which actually lets you keep the built modules by default.

Wondering if that's it's worth building modules. Would the barrier between JS and Wasm allow this to be faster?

It would be sweet to see what perf diff looks like in a JS example that makes many calls into the module, vs plain JS and vs plain AS.

I am looking forward to try both implementations from the browser 😃

asconfig.json

- disable size optimization - disable assertions in production Co-authored-by: Max Graey <[email protected]>

StEvUgnIn · 2021-03-30T10:16:23Z

I have a weird compiler output due to type declared inside modules yet..
https://gist.github.com/StEvUgnIn/acbfed089a24b1c671f79b1a36723a06

But so far, it seems to go well.

Edit:
I have modified the utility bundle-dts.ts, so it now looks for these type problems until I find how to declare types else where using typescript

diff --git a/utils/bundle-dts.js b/utils/bundle-dts.js
index c7bcd55..82be43a 100644
--- a/utils/bundle-dts.js
+++ b/utils/bundle-dts.js
@@ -2,7 +2,7 @@ const fs = require("fs");
 const path = require("path");

 let sourcePath = "./dist/index.d.ts";
-let sourceTypingsPath = "./src/types.d.ts";
+let sourceTypingsPath = "./assembly/index.d.ts";
 let sourceTypings = fs.readFileSync(sourceTypingsPath, "utf-8");
 let typings = fs.readFileSync(sourcePath, "utf-8");
 let typingsLength = typings.length;
@@ -37,4 +37,12 @@ typings = "\n" + sourceTypings.replace(/declare/g, "export") + "\n" + typings;
 // Wrap them in a "gl-matrix module"
 typings = 'declare module "gl-matrix" {\n' + typings + "\n}";

+// Place assemblyscript reference path to the top
+typings = typings.replace(/\n\n\/\/\/ <reference path=\"[^\"]+?\" \/>/g, "");
+
+typings = `
+/// <reference path="../node_modules/assemblyscript/std/portable/index.d.ts" />\n
+${typings}
+`;
+
 fs.writeFileSync(sourcePath, typings, "utf-8");

StEvUgnIn · 2021-03-30T15:58:25Z

JavaScript output now renders

production build achieved from assembly

esm and cjs are produced by tsc rollup build all wasm loaders

StEvUgnIn

This work finalizes the first build targeting Javascript and Webassembly.

must declare hypot3, hypot4, hypot7, ... each for function overloading moved namespace Math into maths.ts

StEvUgnIn

rollup supports operation for both release and debug script allows to produce the exports for each loader files loader is compiled from JS using typescript but babel is supported

StEvUgnIn · 2021-04-02T22:00:42Z

loader/index.js

+
+let modules;
+
+wasm({ ...imports }).then(instance => {


This is temporary, before I implement a better solution for exporting WebAssembly modules. Solutions are either:

~~Making a WASM file for each module (curently max size for synchronous compilation is 4KB). Current WASM file is >100KB with -O3 optimization~~

Complying on @assemblyscript/loader using loader.instantiateStreaming

Develop a processor script to pass <script> to WebAssembly using eval or some callback and DOM for moving executed elements to <noscript>

Accessing modules using Direct Memory Access https://www.assemblyscript.org/loader.html#direct-memory-access

Make the synchronous Instantiation in a WebWorker or another Thread https://developer.mozilla.org/en-US/docs/Tools/Performance/Scenarios/Intensive_JavaScript

WebAssembly.Module.exports()

I'm currently experimenting with as-bind

global function min cannot be accessed inside class when overriden asconfig.json: tdsFiles, exportRuntime, runtime set to incremental

moved loader release and debug to assembly/loader use as-bind for importing AS wasm loader produces declaration files only

prepare build system for as-pect files

default configuration copied and renamed mocha tests from *.js into *.spec.ts

mrchantey · 2022-02-21T01:12:52Z

32 Bit Support

This PR is great! I'm in the process of implementing the brach in my project now.
I'd just like to flag the 64 bit operations. We may want to have flexibility, for either allowing users to make the call at runtime, or exporting two seperate builds.
For starters we could declare something like the following in common.ts and then use it throughout the library (I have no idea if this actually compiles)

//64 
export type Float = f64
export type FloatArray = Float64Array
export const FloatMath = Math

//32
export type Float = f32
export type FloatArray = Float32Array
export const FloatMath = Mathf

StEvUgnIn · 2022-02-21T12:36:45Z

Hello @mrchantey,

Please you are welcome for trying and sharing your proposition.

StEvUgnIn · 2023-01-31T14:00:48Z

I didn't make any advancement on this PR. I was waiting for as-bind to support Array/Float32Array/Float64Array before going any further.

StEvUgnIn added 5 commits March 27, 2021 11:25

configuring env for working with assemblyscript

65f3513

porting js into as

600fc7d

set assemblyscript portability for AS/TS

68c0b01

update gitignore - yarn

758766d

configuration for compilation of AS into JS

2239143

StEvUgnIn added 6 commits March 27, 2021 14:57

add source types declarations for build

b61761e

fix required explicit toString conversion

4276d9c

fix module typings

fd1907b

implement workaround for AS100

f917c0c

tsc build dist/index.dts from portable AS directly

2e2ac0b

build successfully javascript and webassembly

a53c4e3

StEvUgnIn added 4 commits March 29, 2021 17:45

removed directive for TS typings

6f18cce

another fix to AS100 for expected closure

f1b573b

fix AS warnings

6ff09f6

optimize MathUtil library

6deca79

MaxGraey reviewed Mar 29, 2021

View reviewed changes

asconfig.json Outdated Show resolved Hide resolved

optimize build for speed

dc5e7da

- disable size optimization - disable assertions in production Co-authored-by: Max Graey <[email protected]>

StEvUgnIn added 3 commits March 30, 2021 14:48

fix modules in dist/index.d.ts

cca26fa

compile from single file index.ts

598eff0

changetype is not implemented for TS compilation

28f978a

StEvUgnIn added 4 commits March 30, 2021 20:57

change MathUtil into JSMath and Maths namespaces

0749891

merge JSMath and Maths and toolchain TS into AMD modules

36ecee9

production build achieved from assembly

simplify toolchain to compile TS/AS into JS

79a3b97

definitive toolchain compilation

8a56b64

esm and cjs are produced by tsc rollup build all wasm loaders

StEvUgnIn force-pushed the assemblyscript branch from 3a12ac0 to 8a56b64 Compare April 1, 2021 21:36

StEvUgnIn commented Apr 1, 2021

View reviewed changes

StEvUgnIn mentioned this pull request Apr 1, 2021

[AssemblyScript] gl-matrix port to WebAssembly #420

Open

3 tasks

hypot cannot be parsed in JS build

78a6d91

must declare hypot3, hypot4, hypot7, ... each for function overloading moved namespace Math into maths.ts

StEvUgnIn commented Apr 2, 2021

View reviewed changes

StEvUgnIn added 2 commits April 2, 2021 21:55

javascript interface for webassembly

0dd49ae

rollup supports operation for both release and debug script allows to produce the exports for each loader files loader is compiled from JS using typescript but babel is supported

update .travis.yml for using latest node-lts version

194ed13

StEvUgnIn commented Apr 2, 2021

View reviewed changes

StEvUgnIn added 6 commits April 4, 2021 11:51

add upper case support

1922b8d

right asynchronous call for WebAssembly loading

1124e84

update assembly and asconfig.json

885e3b1

global function min cannot be accessed inside class when overriden asconfig.json: tdsFiles, exportRuntime, runtime set to incremental

loader

2b03776

moved loader release and debug to assembly/loader use as-bind for importing AS wasm loader produces declaration files only

build

32801c0

prepare build system for as-pect files

as-pect

ae420e4

default configuration copied and renamed mocha tests from *.js into *.spec.ts

stefnotch mentioned this pull request May 24, 2021

Performance is now extremely slow on modern browsers #359

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AssemblyScript] porting source from JS to AS #421

[AssemblyScript] porting source from JS to AS #421

StEvUgnIn commented Mar 27, 2021

StEvUgnIn commented Mar 27, 2021 •

edited

Loading

trusktr commented Mar 28, 2021

StEvUgnIn commented Mar 28, 2021

StEvUgnIn commented Mar 30, 2021 •

edited

Loading

StEvUgnIn commented Mar 30, 2021

StEvUgnIn left a comment

StEvUgnIn left a comment

StEvUgnIn Apr 2, 2021 •

edited

Loading

StEvUgnIn Apr 3, 2021

StEvUgnIn May 1, 2021

mrchantey commented Feb 21, 2022 •

edited

Loading

StEvUgnIn commented Feb 21, 2022

StEvUgnIn commented Jan 31, 2023

[AssemblyScript] porting source from JS to AS #421

Are you sure you want to change the base?

[AssemblyScript] porting source from JS to AS #421

Conversation

StEvUgnIn commented Mar 27, 2021

StEvUgnIn commented Mar 27, 2021 • edited Loading

trusktr commented Mar 28, 2021

StEvUgnIn commented Mar 28, 2021

StEvUgnIn commented Mar 30, 2021 • edited Loading

StEvUgnIn commented Mar 30, 2021

StEvUgnIn left a comment

Choose a reason for hiding this comment

StEvUgnIn left a comment

Choose a reason for hiding this comment

StEvUgnIn Apr 2, 2021 • edited Loading

Choose a reason for hiding this comment

StEvUgnIn Apr 3, 2021

Choose a reason for hiding this comment

WebAssembly.Module.exports()

StEvUgnIn May 1, 2021

Choose a reason for hiding this comment

mrchantey commented Feb 21, 2022 • edited Loading

32 Bit Support

StEvUgnIn commented Feb 21, 2022

StEvUgnIn commented Jan 31, 2023

StEvUgnIn commented Mar 27, 2021 •

edited

Loading

StEvUgnIn commented Mar 30, 2021 •

edited

Loading

StEvUgnIn Apr 2, 2021 •

edited

Loading

mrchantey commented Feb 21, 2022 •

edited

Loading