fix: duplication occurs when card view is switched to embed view #8407

akumatus · 2024-09-19T10:37:22Z

Fix issue BS-1373.

What changed?

Use a temporary constant for this.focusModel .
Add e2e tests for YouTube and Figma view switching scenarios.

changeset-bot · 2024-09-19T10:37:25Z

⚠️ No Changeset found

Latest commit: 4e8a84f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-09-19T10:37:26Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
blocksuite	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 20, 2024 3:15am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
blocksuite-docs	⬜️ Ignored (Inspect)	Visit Preview		Sep 20, 2024 3:15am

graphite-app · 2024-09-19T10:37:27Z

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

akumatus · 2024-09-19T10:37:55Z

fix: duplication occurs when card view is switched to embed view #8407 👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @akumatus and the rest of your teammates on Graphite

nx-cloud · 2024-09-19T10:38:39Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4e8a84f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

nx vite:build @blocksuite/playground

Sent with 💌 from NxCloud.

github-actions · 2024-09-19T10:39:15Z

size-limit report 📦

Path	Size
@blocksuite/affine	13 B (0%)
@blocksuite/affine/effects	2.02 MB (+0.02% 🔺)
@blocksuite/affine/block-std	145.23 KB (0%)
@blocksuite/affine/block-std/gfx	75.93 KB (0%)
@blocksuite/affine/global	13 B (0%)
@blocksuite/affine/global/utils	13.82 KB (0%)
@blocksuite/affine/global/env	231 B (0%)
@blocksuite/affine/global/exceptions	552 B (0%)
@blocksuite/affine/global/di	1.65 KB (0%)
@blocksuite/affine/global/types	13 B (0%)
@blocksuite/affine/store	69.09 KB (0%)
@blocksuite/affine/inline	29.04 KB (0%)
@blocksuite/affine/inline/consts	51 B (0%)
@blocksuite/affine/inline/types	13 B (0%)
@blocksuite/affine/presets	1.83 MB (+0.02% 🔺)
@blocksuite/affine/blocks	1.91 MB (+0.01% 🔺)
@blocksuite/affine/blocks/schemas	83.7 KB (0%)

graphite-app · 2024-09-20T03:14:04Z

Merge activity

Sep 19, 11:14 PM EDT: akumatus added this pull request to the Graphite merge queue.
Sep 19, 11:20 PM EDT: akumatus merged this pull request with the Graphite merge queue.

Fix issue [BS-1373](https://linear.app/affine-design/issue/BS-1373). ### What changed? - Use a temporary constant for `this.focusModel `. - Add e2e tests for YouTube and Figma view switching scenarios.

github-actions bot assigned akumatus Sep 19, 2024

vercel bot deployed to Preview – blocksuite September 19, 2024 10:38 View deployment

akumatus marked this pull request as ready for review September 19, 2024 10:41

akumatus requested a review from a team as a code owner September 19, 2024 10:41

akumatus force-pushed the fix/change-embed-card-style branch from f686ed4 to 01e77e4 Compare September 19, 2024 10:48

vercel bot deployed to Preview – blocksuite September 19, 2024 10:49 View deployment

akumatus force-pushed the fix/change-embed-card-style branch from 01e77e4 to 3feb0f5 Compare September 19, 2024 10:59

vercel bot deployed to Preview – blocksuite September 19, 2024 11:00 View deployment

akumatus force-pushed the fix/change-embed-card-style branch from 3feb0f5 to a85acea Compare September 19, 2024 12:21

vercel bot deployed to Preview – blocksuite September 19, 2024 12:22 View deployment

doodlewind approved these changes Sep 20, 2024

View reviewed changes

akumatus force-pushed the fix/change-embed-card-style branch 2 times, most recently from 02c41ac to 2f1db83 Compare September 20, 2024 02:33

vercel bot deployed to Preview – blocksuite September 20, 2024 02:35 View deployment

akumatus force-pushed the fix/change-embed-card-style branch from 2f1db83 to fcf4a3b Compare September 20, 2024 03:06

vercel bot deployed to Preview – blocksuite September 20, 2024 03:06 View deployment

akumatus force-pushed the fix/change-embed-card-style branch from fcf4a3b to 3bfc438 Compare September 20, 2024 03:09

vercel bot deployed to Preview – blocksuite September 20, 2024 03:10 View deployment

fix: duplication occurs when card view is switched to embed view (#8407)

4e8a84f

Fix issue [BS-1373](https://linear.app/affine-design/issue/BS-1373). ### What changed? - Use a temporary constant for `this.focusModel `. - Add e2e tests for YouTube and Figma view switching scenarios.

akumatus force-pushed the fix/change-embed-card-style branch from 3bfc438 to 4e8a84f Compare September 20, 2024 03:14

vercel bot deployed to Preview – blocksuite September 20, 2024 03:15 View deployment

graphite-app bot merged commit 4e8a84f into master Sep 20, 2024
36 checks passed

graphite-app bot deleted the fix/change-embed-card-style branch September 20, 2024 03:20

vercel bot deployed to Production – blocksuite September 20, 2024 03:21 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: duplication occurs when card view is switched to embed view #8407

fix: duplication occurs when card view is switched to embed view #8407

akumatus commented Sep 19, 2024 •

edited

Loading

changeset-bot bot commented Sep 19, 2024 •

edited

Loading

vercel bot commented Sep 19, 2024 •

edited

Loading

graphite-app bot commented Sep 19, 2024

akumatus commented Sep 19, 2024

nx-cloud bot commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024 •

edited

Loading

graphite-app bot commented Sep 20, 2024 •

edited

Loading

fix: duplication occurs when card view is switched to embed view #8407

fix: duplication occurs when card view is switched to embed view #8407

Conversation

akumatus commented Sep 19, 2024 • edited Loading

What changed?

changeset-bot bot commented Sep 19, 2024 • edited Loading

⚠️ No Changeset found

vercel bot commented Sep 19, 2024 • edited Loading

graphite-app bot commented Sep 19, 2024

Your org has enabled the Graphite merge queue for merging into master

akumatus commented Sep 19, 2024

nx-cloud bot commented Sep 19, 2024 • edited Loading

☁️ Nx Cloud Report

github-actions bot commented Sep 19, 2024 • edited Loading

size-limit report 📦

graphite-app bot commented Sep 20, 2024 • edited Loading

Merge activity

akumatus commented Sep 19, 2024 •

edited

Loading

changeset-bot bot commented Sep 19, 2024 •

edited

Loading

vercel bot commented Sep 19, 2024 •

edited

Loading

nx-cloud bot commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024 •

edited

Loading

graphite-app bot commented Sep 20, 2024 •

edited

Loading