Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed writing 'vlan' from parameter string #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arthemis95
Copy link

Basically just removing the vlan parameter from the qemu arguments since it's depreciated. I did only change actually putting it in the string, the gui doesn't reflect the changes.

@TBK
Copy link

TBK commented Mar 25, 2019

@pcwizzy37 completely removes vlan with this commit pcwizzy37@37d5447

@tobimensch
Copy link
Owner

I would accept a patch that fixes the GUI and all issues associated with the removal of vlan. There has to be an alternative way of doing those things, or QEMU wouldn't remove that feature, I'd think.

@jake01756
Copy link

How many people would use the vlan replacement? I don't. In issue #58 (comment) might contain the answer for a replacement.

I found out this commit, which removes the vlan parameter:
qemu/qemu@af1a5c3

the commit message says...

...should have
been enough time for everybody to either just drop unnecessary "vlan=0"
parameters, to switch to the modern -device + -netdev syntax for connecting
guest NICs with host network backends, or to switch to the "hubport" netdev
in case hubs are really wanted instead.

So how hard would it be to implement a replacement to fix this issue? To me it doesn't seem that hard but, things always seem easier than they are to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants