Avoid try/except on import (equinor#1257)

setup.py

@@ -5,7 +5,7 @@
 
 TESTS_REQUIRE = [
     "bandit",
-    "black>=22.1",
+    "black>=22.1,<24",
     "dash[testing]",
     "flaky",
     "isort",

webviz_subsurface/_datainput/eclipse_init_io/pvt_common.py

@@ -37,27 +37,26 @@
 ########################################
 
 import abc
+import sys
 import warnings
 from enum import Enum
 from typing import Any, Callable, List, Optional, Tuple, Union
 
 import numpy as np
 from scipy import interpolate
 
+from ..eclipse_unit import ConvertUnits, EclUnitEnum, EclUnits
+from ..units import Unit
+
 # opm is only available for Linux,
 # hence, ignore any import exception here to make
 # it still possible to use the PvtPlugin on
 # machines with other OSes.
 #
 # NOTE: Functions in this file cannot be used
 #       on non-Linux OSes.
-try:
+if sys.platform == "linux":
     from opm.io.ecl import EclFile
-except ImportError:
-    pass
-
-from ..eclipse_unit import ConvertUnits, EclUnitEnum, EclUnits
-from ..units import Unit
 
 
 class EclPropertyTableRawData:  # pylint: disable=too-few-public-methods

webviz_subsurface/_datainput/eclipse_init_io/pvt_gas.py

@@ -36,22 +36,11 @@
 #
 ########################################
 
+import sys
 from typing import Callable, Optional, Tuple, Union
 
 import numpy as np
 
-# opm is only available for Linux,
-# hence, ignore any import exception here to make
-# it still possible to use the PvtPlugin on
-# machines with other OSes.
-#
-# NOTE: Functions in this file cannot be used
-#       on non-Linux OSes.
-try:
-    from opm.io.ecl import EclFile
-except ImportError:
-    pass
-
 from ..eclipse_unit import ConvertUnits, CreateUnitConverter, EclUnitEnum, EclUnits
 from .pvt_common import (
     EclPhaseIndex,
@@ -64,6 +53,16 @@
     surface_mass_density,
 )
 
+# opm is only available for Linux,
+# hence, ignore any import exception here to make
+# it still possible to use the PvtPlugin on
+# machines with other OSes.
+#
+# NOTE: Functions in this file cannot be used
+#       on non-Linux OSes.
+if sys.platform == "linux":
+    from opm.io.ecl import EclFile
+
 
 class WetGas(PvxOBase):
     """Class holding a PVT interpolant and access methods for PVT data for wet gas

webviz_subsurface/_datainput/eclipse_init_io/pvt_oil.py

@@ -36,22 +36,11 @@
 #
 ########################################
 
+import sys
 from typing import Any, Callable, Optional, Tuple, Union
 
 import numpy as np
 
-# opm is only available for Linux,
-# hence, ignore any import exception here to make
-# it still possible to use the PvtPlugin on
-# machines with other OSes.
-#
-# NOTE: Functions in this file cannot be used
-#       on non-Linux OSes.
-try:
-    from opm.io.ecl import EclFile
-except ImportError:
-    pass
-
 from ..eclipse_unit import ConvertUnits, CreateUnitConverter, EclUnitEnum, EclUnits
 from .pvt_common import (
     EclPhaseIndex,
@@ -65,6 +54,16 @@
     surface_mass_density,
 )
 
+# opm is only available for Linux,
+# hence, ignore any import exception here to make
+# it still possible to use the PvtPlugin on
+# machines with other OSes.
+#
+# NOTE: Functions in this file cannot be used
+#       on non-Linux OSes.
+if sys.platform == "linux":
+    from opm.io.ecl import EclFile
+
 
 class LiveOil(PvxOBase):
     """Class holding a PVT interpolant and access methods for PVT data for live oil

webviz_subsurface/_datainput/eclipse_init_io/pvt_water.py

@@ -36,22 +36,11 @@
 #
 ########################################
 
+import sys
 from typing import Any, Callable, List, Optional, Union
 
 import numpy as np
 
-# opm is only available for Linux,
-# hence, ignore any import exception here to make
-# it still possible to use the PvtPlugin on
-# machines with other OSes.
-#
-# NOTE: Functions in this file cannot be used
-#       on non-Linux OSes.
-try:
-    from opm.io.ecl import EclFile
-except ImportError:
-    pass
-
 from ..eclipse_unit import ConvertUnits, CreateUnitConverter, EclUnitEnum, EclUnits
 from .pvt_common import (
     EclPhaseIndex,
@@ -62,6 +51,16 @@
     surface_mass_density,
 )
 
+# opm is only available for Linux,
+# hence, ignore any import exception here to make
+# it still possible to use the PvtPlugin on
+# machines with other OSes.
+#
+# NOTE: Functions in this file cannot be used
+#       on non-Linux OSes.
+if sys.platform == "linux":
+    from opm.io.ecl import EclFile
+
 
 class WaterImpl(PvxOBase):
     """Class holding a PVT interpolant and access methods for PVT data for water"""

webviz_subsurface/_datainput/pvt_data.py

@@ -10,6 +10,13 @@
 
 import numpy as np
 import pandas as pd
+from webviz_config.common_cache import CACHE
+from webviz_config.webviz_store import webvizstore
+
+from .eclipse_init_io.pvt_gas import Gas
+from .eclipse_init_io.pvt_oil import Oil
+from .eclipse_init_io.pvt_water import Water
+from .fmu_input import load_csv, load_ensemble_set
 
 # opm and res2df are only available for Linux,
 # hence, ignore any import exception here to make
@@ -18,19 +25,9 @@
 #
 # NOTE: Functions in this file cannot be used
 #       on non-Linux OSes.
-try:
+if sys.platform == "linux":
     import res2df
     from opm.io.ecl import EclFile
-except ImportError:
-    pass
-
-from webviz_config.common_cache import CACHE
-from webviz_config.webviz_store import webvizstore
-
-from .eclipse_init_io.pvt_gas import Gas
-from .eclipse_init_io.pvt_oil import Oil
-from .eclipse_init_io.pvt_water import Water
-from .fmu_input import load_csv, load_ensemble_set
 
 
 @CACHE.memoize()