Fix a race condition when restoring pane contents #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the pane contents files are deleted too quickly then pane contents restoration fails. Cleanup previous content JiT before a restore rather than after a restore has happened to avoid this
Can you please explain your understanding of how this happens?
How come there IS previous content? My understanding is we delete it after restore is completed. |
|
Hi - I cannot remember the details exactly now as it was a few weeks back but basically I found that if there is a lot of load on the system the contents files could be deleted before tmux got a chance to read from them. With this patch it never happens since old contents are deleted only when new ones need to be written. Answering your second question: there can be previous content because with this patch it is deleted "lazily". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the pane contents files are deleted too
quickly then pane contents restoration fails.
Cleanup previous content JiT before a restore
rather than after a restore has happened to
avoid this