Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow children of tmux to be saved #314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spencerbutler
Copy link

I noticed that your awesome plugin was not saving all my ssh sessions. Although my use case was different than those in #264, I added a comment there with my issue. The following PR builds on what I originally posted there.

cheers

@bruno-
Copy link
Member

bruno- commented Nov 1, 2019

Based on what I understood from #264 are you saying you're running ssh directly from tmux?
Something like $ tmux new-window 'ssh yourdomain.com'?

If the above is true, then I'm not sure we want to support that. It's an edge case that adds complexity. The binding from #264 can easily be changed to: open new pane/window with a terminal + start ssh. With this change everything should work just fine.

@spencerbutler
Copy link
Author

I don't see this as an edge case. Not everyone spawns (or wants to spawn) a new shell for every new window. I also don't understand the complexity this introduces. You only support a handful of programs to restore, and this is added at the end of that discovery process before giving up.

Is there a less complex way I could include such child processes? Are there others that would appreciate restoring the children of tmux?

@MattBystrin
Copy link

MattBystrin commented Apr 17, 2022

@bruno-,
I don't see this as an edge case too. It is very comfortable to open some apps like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants