new web: fix build issue #4098
Merged
new web: fix build issue #4098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to useConfigureUrbitClient (introduction of some RN polyfill imports which have no RN web equivalent) was causing the new web app build to fail.
This PR moves the native-only polyfill imports out to a
.native.tsspecific file and adds apolyfill.tsfile that will work for web.packages/app/hooks/useConfigureUrbitClient.ts: Replaced individual polyfill calls withinitializePolyfillsand changed the fetch method toplatformFetch. [1] [2]packages/app/platform/polyfills.native.ts: AddedinitializePolyfillsfunction to handle polyfill initialization and exportedplatformFetchfor the native environment.packages/app/platform/polyfills.ts: AddedinitializePolyfillsfunction as a no-op and exportedplatformFetchfor the web environment.Tested on iOS simulator, network requests appear to function normally.