lure: provide a fallback url if branch.io is blocked (or down) #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patosullivan
requested review from
jamesacklin,
alecananian,
arthyn and
latter-bolden
jamesacklin
approved these changes
Oct 11, 2023
|
The share URL is falling back to the original URL when the deep link one is Could be enough to just return |
patosullivan
deleted the
po/land-1047-provide-fallback-if-branchio-blocked
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LAND-1047
Apparently branch.io appears on many adblock lists. (see BranchMetrics/web-branch-deep-linking-attribution#538)
We were only returning a lure link if we could successfully create a deep link. We should return the normal/non-branch lure link if we fail to contact branch.io.