Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rollup@4 support #178

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

tbouffard
Copy link
Contributor

The build depends on [email protected] as of d41acd7 and the CI jobs pass.
The version of the plugin has been confirmed to work with rollup by at least 2 people.

Notes

The package-lock.json file was incorrectly updated by #176 which wrongly updated the rollup peerDependencies field from to from ^2 || ^3 to ^4.2.0

Closes #174

Copy link

changeset-bot bot commented Nov 22, 2023

🦋 Changeset detected

Latest commit: 49d666f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
rollup-plugin-sizes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tbouffard tbouffard marked this pull request as ready for review November 22, 2023 16:04
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d41acd7) 94.54% compared to head (49d666f) 94.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #178   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files           1        1           
  Lines          55       55           
  Branches       15       15           
=======================================
  Hits           52       52           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tivac tivac merged commit 2ba0ba1 into tivac:main Nov 23, 2023
12 checks passed
@github-actions github-actions bot mentioned this pull request Nov 23, 2023
@tbouffard tbouffard deleted the feat/add_support_rollup_v4 branch November 23, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for rollup@4
3 participants