chore: only .toString() if dirty (#966)

* chore: only .toString() if dirty * Create tricky-cats-fail.md
tivac · Aug 8, 2023 · ffab76d · ffab76d
1 parent 880b5a2
commit ffab76d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/.changeset/tricky-cats-fail.md b/.changeset/tricky-cats-fail.md
@@ -0,0 +1,5 @@
+---
+"@modular-css/processor": patch
+---
+
+chore: only .toString() if dirty when replacing `@value` references
diff --git a/packages/processor/plugins/values-replace.js b/packages/processor/plugins/values-replace.js
@@ -34,6 +34,7 @@ module.exports = () => ({
         const replacer = (prop) =>
             (thing) => {
                 const parsed = value(thing[prop]);
+                let modified = false;
 
                 parsed.walk((node) => {
                     if(node.type !== "word" || !values[node.value]) {
@@ -47,9 +48,13 @@ module.exports = () => ({
 
                     // Replace any value instances
                     node.value = current.value;
+
+                    modified = true;
                 });
 
-                thing[prop] = parsed.toString();
+                if(modified) {
+                    thing[prop] = parsed.toString();
+                }
             };
 
         return {