Update golang.org/x/tools to v0.12.0 #3883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary for tools 0.9.0, which started lifting those since golang/tools@71ea8f1
This requires updating test data, due to the change noted in the previous commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required handling array and struct zero constants, due to golang/tools@71ea8f1. I implemented that the same way as channels, which I hope is correct. At least, it appears to work for tests that I am able to run, but we'll see how it is with the more extensive checks on CI.
This also triggers an update of
golang.org/x/sys, but that is only used for a constant and should be fine.