Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nRF52: set SPI TX/RX lengths even data is empty. Fixes #3868 #3877

Merged
merged 2 commits into from
Aug 24, 2023
Merged

nRF52: set SPI TX/RX lengths even data is empty. Fixes #3868 #3877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d444983
Set SPI TX/RX lengths even data is empty. Fixes #3868
Aug 21, 2023
d3a4e8c
Refactor spi.TX to get cleaner look
Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions src/machine/machine_nrf52xxx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,24 +288,27 @@ func (spi SPI) Tx(w, r []byte) error {
// supported.
for len(r) != 0 || len(w) != 0 {
// Prepare the SPI transfer: set the DMA pointers and lengths.
if len(r) != 0 {
spi.Bus.RXD.PTR.Set(uint32(uintptr(unsafe.Pointer(&r[0]))))
n := uint32(len(r))
if n > 255 {
n = 255
// read buffer
nr := uint32(len(r))
if nr > 0 {
if nr > 255 {
nr = 255
}
spi.Bus.RXD.MAXCNT.Set(n)
r = r[n:]
spi.Bus.RXD.PTR.Set(uint32(uintptr(unsafe.Pointer(&r[0]))))
r = r[nr:]
}
if len(w) != 0 {
spi.Bus.TXD.PTR.Set(uint32(uintptr(unsafe.Pointer(&w[0]))))
n := uint32(len(w))
if n > 255 {
n = 255
spi.Bus.RXD.MAXCNT.Set(nr)

// write buffer
nw := uint32(len(w))
if nw > 0 {
if nw > 255 {
nw = 255
}
spi.Bus.TXD.MAXCNT.Set(n)
w = w[n:]
spi.Bus.TXD.PTR.Set(uint32(uintptr(unsafe.Pointer(&w[0]))))
w = w[nw:]
}
spi.Bus.TXD.MAXCNT.Set(nw)

// Do the transfer.
// Note: this can be improved by not waiting until the transfer is
Expand Down
Loading