compiler: add compiler-rt and wasm symbols to table #3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykevl
approved these changes
Jul 31, 2023
| @@ -12,6 +12,7 @@ import ( | |||
| "path/filepath" | |||
| "time" | |||
|
|
|||
| wasm "github.com/aykevl/go-wasm" | |||
There was a problem hiding this comment.
Note that the package is already named "wasm", so this would be fine:
Suggested change
| wasm "github.com/aykevl/go-wasm" | |
| "github.com/aykevl/go-wasm" |
(Many people think the directory name is used, but that's not true: the name from package wasm is used).
aykevl
reviewed
Jul 31, 2023
| @@ -7,6 +7,7 @@ | |||
| "goarch": "arm", | |||
| "linker": "wasm-ld", | |||
| "libc": "wasi-libc", | |||
| "rtlib": "compiler-rt", | |||
There was a problem hiding this comment.
Actually now I realize this probably needs to be added to targets/wasm.json too. Feel free to make a new PR if you'd like.
There was a problem hiding this comment.
New PR for wasm.json #3848
|
@charlie-haley FYI: #4188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
compiler-rtand updates themakeArchivefunction to read symbols from wasm binaries and add them to the symbol table.Fixes #3501