Use architecture-specific version of math.h #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykevl
force-pushed
the
arm-math
branch
5 times, most recently
from
2f5397b
to
fe989ba
Compare
Apparently there were some updates which meant that there wasn't a default LLVM version installed anymore?
It looks like math.h is the _only_ file that is architecture specific, and apparently I missed it while adding ARM support.
|
Also fixed a CI issue. |
aykevl
added a commit
to tinygo-org/tinygo
that referenced
this pull request
Mar 3, 2024
They should, but we weren't testing this. I discovered this while working on tinygo-org/macos-minimal-sdk#4 which will likely make math.h not work anymore. So I wanted to make sure we have a test in place before we update that dependency.
This was referenced Mar 3, 2024
aykevl
added a commit
to tinygo-org/tinygo
that referenced
this pull request
May 25, 2024
They should, but we weren't testing this. I discovered this while working on tinygo-org/macos-minimal-sdk#4 which will likely make math.h not work anymore. So I wanted to make sure we have a test in place before we update that dependency.
deadprogram
pushed a commit
to tinygo-org/tinygo
that referenced
this pull request
May 29, 2024
They should, but we weren't testing this. I discovered this while working on tinygo-org/macos-minimal-sdk#4 which will likely make math.h not work anymore. So I wanted to make sure we have a test in place before we update that dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #2 (comment)
@QuLogic can you take a look?