Server side (ec)dhe #113
Merged
Server side (ec)dhe #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alexmgr
commented
Dec 22, 2017
alexmgr
commented
- This allows writing TLS 1.0-1.2 ephemeral servers
- Move PMS derivation for DHE into the "state" machine - Add a function in TLSContext to generate signed dhe ske
- PMS should have never been set in "get_client_dh_pubkey". This was fixed, but requires fixing the UT also.
|
integration tests seem to be failing, but for unrelated reasons. Cloudflare might not be supporting TLS 1.3 draft 18 anymore. |
Closed
|
:+1 looking fine; the failing test also fails on master. crosschecked tls13.cloudflare.com negotiates tls1.3-draft (chrome). created bug #114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.