Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls_1_3-client.py - TLS_1_3 client example fails integration external tests #114

Open
tintinweb opened this issue Jan 2, 2018 · 2 comments
Labels

Comments

@tintinweb
Copy link
Owner

integration test: tls_1_3-client.py is currently failing:

WARNING: No route found for IPv6 destination :: (no default route?)
###[ SSL/TLS ]###
  \records   \

TLS Session Context:
    negotiated.version: UNKNOWN
    negotiated.ciphersuite: UNKNOWN
    negotiated.key_exchange: None
    negotiated.encryption: None
    negotiated.mac: None
    negotiated.compression: 0
    negotiated.resumption: False
    encrypted_premaster_secret: None
    premaster_secret: None
    master_secret: None
    early_secrets: None
    handshake_secrets: None
    master_secrets: None
    resumption_secret: None

    Client TLS context:
        random: 'ZJ\xcd\xe9X\x94\xbb\x8b=\xf9n\x1a\xfb\xd7\x1aZ\xbe\x84#^\x98\xea\x06\x1d\x14P\x15?\x84!\xeaW'
        session id: ''
        shares:
            ECDH Keystore:
            curve: secp256r1
            size: 256
            public: (65784327905464346414202945536039495226631169475038061124155754132953411300665, 111358793915316823269442380408231802709386467896961374510920245456591311874104) on "secp256r1" => y^2 = x^3 + 115792089210356248762697446949407573530086143415290314195533631308867097853948x + 41058363725152142129326129780047268409114441015993725554835256314039467401291 (mod 115792089210356248762697446949407573530086143415290314195533631308867097853951)
            private: 38277140221663347036400194175171131568162567488489668401868155075649733424459
        finished:
            secret: None
            finished hashes:
        Empty Asymmetrical Keystore:
            certificate: None
            size: 0
            public: None
            private: None
        <scapy_ssl_tls.ssl_tls_keystore.EmptyKexKeystore object at 0x98850ac>
        <scapy_ssl_tls.ssl_tls_keystore.EmptySymKeyStore object at 0x988516c>
        symetric keystore history:


    Server TLS context:
        random: None
        session id: None
        shares:

        finished:
            secret: None
            finished hashes:
        Empty Asymmetrical Keystore:
            certificate: None
            size: 0
            public: None
            private: None
        <scapy_ssl_tls.ssl_tls_keystore.EmptyKexKeystore object at 0x988552c>
        <scapy_ssl_tls.ssl_tls_keystore.EmptySymKeyStore object at 0x988556c>
        symetric keystore history:

Traceback (most recent call last):
  File "examples/tls_1_3-client.py", line 58, in <module>
    sys.exit(main())
  File "examples/tls_1_3-client.py", line 46, in main
    r = tls_socket.do_round_trip(TLSHandshakes(handshakes=[TLSHandshake() / TLSFinished(data=tls_socket.tls_ctx.get_verify_data())]), recv=False)
  File "/usr/local/lib/python2.7/dist-packages/scapy_ssl_tls/ssl_tls_crypto.py", line 600, in get_verify_data
    prf_verify_data = self.prf.get_bytes(self.master_secret, label,
AttributeError: 'NoneType' object has no attribute 'get_bytes'

example was introduced with: c76c2a6
cmd: python examples/tls_1_3-client.py tls13.cloudflare.com 443
scapy-ssl_tls checkout of c76c2a6 also fails with same error against cloudflare.

verified tls13.cloudflare.com negotiates tls1.3-draft with chrome (requires manual step to enable it)

@alexmgr do we want to fix this before releasing the 2.0 (current master)?

@alexmgr
Copy link
Collaborator

alexmgr commented Jan 8, 2018

Hey @tintinweb,

Didn't look into this, might be negotiating another draft version then what we have (18). Don't have much time right now, might disable the test?

@higher75
Copy link

Hey man, I also found this error recently. Can you tell me how to solve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants