align everforest colors with other themes and shells #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi.
current Everforest colors assignment differs a lot from both Everforest palette's intentions https://github.com/sainnhe/everforest/blob/master/palette.md and screenshots https://github.com/sainnhe/everforest/blob/master/README.md
this leads eg to partially unusable theme in tinted-shell https://github.com/tinted-theming/tinted-shell/blob/0c0cc5b7d262136a8598384d00f882b49464eb07/scripts/base16-everforest.sh#L8 - color00 is the same as color_background, causing inline shell comments to be invisible (try typing eg
% true # this is comment
- you'll see only cmd)in this pr i align color assingments with other themes in which green is green etc. for instance i've fixed (git) diff adds/removals to be red/green instead of blue/aqua (as they should be according to both tinted-theming & Everforest guidelines).
proper shell coloring is present eg in Gogh here (at least
COLOR_02..COLOR_07
) and looks as expected - so i took those into account too (there's ongoing work to rebase Gogh onto tinted-theming schemes)