Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align everforest colors with other themes and shells #27

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

sergiorussia
Copy link
Contributor

hi.

current Everforest colors assignment differs a lot from both Everforest palette's intentions https://github.com/sainnhe/everforest/blob/master/palette.md and screenshots https://github.com/sainnhe/everforest/blob/master/README.md

this leads eg to partially unusable theme in tinted-shell https://github.com/tinted-theming/tinted-shell/blob/0c0cc5b7d262136a8598384d00f882b49464eb07/scripts/base16-everforest.sh#L8 - color00 is the same as color_background, causing inline shell comments to be invisible (try typing eg % true # this is comment - you'll see only cmd)

in this pr i align color assingments with other themes in which green is green etc. for instance i've fixed (git) diff adds/removals to be red/green instead of blue/aqua (as they should be according to both tinted-theming & Everforest guidelines).

proper shell coloring is present eg in Gogh here (at least COLOR_02..COLOR_07) and looks as expected - so i took those into account too (there's ongoing work to rebase Gogh onto tinted-theming schemes)

@sergiorussia sergiorussia requested a review from a team as a code owner August 21, 2024 18:35
@sergiorussia
Copy link
Contributor Author

sergiorussia commented Aug 21, 2024

current tinted-shell based with selected everforest theme
Screenshot from 2024-08-21 22-29-09

  • invisible comment (color 0 = background)
  • swapped colors (blue instead of red, aqua instead of green)

fixed colors (Gogh's theme rebased on tinted theme with the fix)
Screenshot from 2024-08-21 22-27-01

if we magnify a bit screenshot from Everforest's author @sainnhe reference image
image
it's clear to me that the fixed version looks as intented (and consistent with many other themes)

Copy link
Member

@JamyGolden JamyGolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great fix, thanks @sergiorussia!

@JamyGolden JamyGolden merged commit 43ba59b into tinted-theming:spec-0.11 Aug 22, 2024
1 check passed
@sergiorussia sergiorussia deleted the everforest-fix branch August 22, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants