POC Compose Desktop #32
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
timrijckaert
commented
Feb 20, 2022
•
timrijckaert
commented
- Show list of Programs
- Add Decompose
Disable for now since it is jumping all over the place
Disable for now since it is jumping all over the place
timrijckaert
commented
Feb 21, 2022
| ) | ||
|
|
||
| // delay(status.media.duration.seconds) | ||
| delay(5.seconds) |
There was a problem hiding this comment.
It's a POC but why do we need the delay?
Was it exiting too quickly?
There was a problem hiding this comment.
Yes, otherwise it exists immediately. load just sends a command to the Chromecast and immediately returns similar to sending a POST.
timrijckaert
commented
Feb 21, 2022
| mockk = "io.mockk:mockk:v1.10.2" | ||
|
|
||
| kotlin-gradle = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlin" } | ||
|
|
||
| chromecast = { module = "su.litvak.chromecast:api-v2", version.ref="chromecast" } | ||
| jackson-annotations = { module ="com.fasterxml.jackson.core:jackson-annotations", version.ref="jackson" } | ||
| jackson-databind = { module ="com.fasterxml.jackson.core:jackson-databind", version.ref="jackson" } |
There was a problem hiding this comment.
For some reason we had to manually include jackson, it wasn't being pulled from the Chromecast dependency.
timrijckaert
commented
Feb 21, 2022
| public suspend fun example() { | ||
| val cast = discovery( | ||
| // Ip-address of MacOs WiFi Adapter. | ||
| InetAddress.getByAddress(byteArrayOf(192.toByte(), 168.toByte(), 0, 246.toByte())) |
There was a problem hiding this comment.
OK for the POC, but a follow-up question can this be discovered dynamically?
There was a problem hiding this comment.
Yes, absolutely. Still have to write a piece of code that uses NetworkInterfaces and retrieves the currently active ethernet adapter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.