Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Font configuration (font and font size) #341

Closed
wants to merge 5 commits into from

Conversation

rkmax
Copy link

@rkmax rkmax commented May 30, 2023

A couple of weeks ago I brought a StreamDeck MK.2 and thanks to this project I was able to migrate from my old macro pad quickly.

Description of changes

Add the feature of changing the font and font size of the button's text.

Hopefully, this MR follows the conventions of your project, let me know if something else is missing to move forward with this MR

Preview Before

image

Preview After

image

rkmax added 5 commits May 30, 2023 08:10
🐛 fix(config.py): fix DEFAULT_FONT path
🐛 fix(display/text_filter.py): remove unused import and fix font path
✨ feat(gui.py): add font selection combo box and support for setting button font
…lignment

🎨 style(main.ui): add font size selection field
🎨 style(main.ui): adjust row and column numbers for some items
🎨 style(main.ui): adjust layout for text font selection and font size fields
🐛 fix(resources_rc.py): update resource file
🐛 fix(ui_main.py): update UI code to match changes in main.ui file
🐛 fix(api.py): fix font size not being set for text filters
✨ feat(api.py): add support for setting font size for buttons in state file

🐛 fix(gui.py): fix line length by splitting long lines
✨ feat(gui.py): add support for setting button text font size
✨ feat(api.py): add support for button text vertical alignment
🐛 fix(gui.py): fix typo in dimmer_options dictionary
✨ feat(gui.py): add support for changing button text font size
@coolapso
Copy link

HI, seems the main project as reached a stale state as the project owner seems to have disappeared, and we are trying to keep it alive.

you are welcome to participate in the discussion here: #357 so we can actually decide a path forward and hopefully accept your contribution into it.

@rkmax
Copy link
Author

rkmax commented Jul 23, 2023

HI, seems the main project as reached a stale state as the project owner seems to have disappeared, and we are trying to keep it alive.

you are welcome to participate in the discussion here: #357 so we can actually decide a path forward and hopefully accept your contribution into it.

Awesome!

@coolapso
Copy link

@rkmax feel free to move this PR to: https://github.com/streamdeck-linux-gui/streamdeck-linux-gui

please be sure to read the new contribution guide specially in regard to git commits.

@rkmax
Copy link
Author

rkmax commented Jul 27, 2023

@rkmax feel free to move this PR to: https://github.com/streamdeck-linux-gui/streamdeck-linux-gui

please be sure to read the new contribution guide specially in regard to git commits.

understood!

@rkmax rkmax closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants