Fix parse_cache_header
signature change
#767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base.parse_cache_headers
removed its keywordsrcfiles_only
in JuliaLang/julia#49866, which makes Revise non-functional in nightly.There are a bunch of other test failures, and I'm not sure I understand the internals enough to address them, but I could identify least two sources (there are probably more):
LoadError
seems to now (sometimes?) hold aMeta.ParseError
value for its.error
field, breaking a few tests which expect aString
instead. A bunch of related error messages seem to have changed too.Pkg
(the associated(::PkgData).info.files
is empty, probably that's because of that), breaking related tests.Anyway, we can probably merge this fix and worry about other failures on
nightly
later, such thatRevise
works again on nightly. Or if anyone wants to address nightly failures in a wider swath, that works for me too.