Support wave-form plotting for BlepSynth #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just one more comment on this code: I saw that if you use a very small pulse_width and make sync really high then not all pulses will be visible. A higher number of samples would help, but I think we may want to make the minimum pulse width depend on the sync factor (to plot a wider pulse in order to be able to display it properly). But such fine tuning would be easier if the wave form would be displayed. Btw, an alternative to sampling the wave form would be a line-segment representation. |
sub_phase reset wasn't implemented properly Signed-off-by: Stefan Westerfeld <[email protected]>
The code from plotblep.py was C++ified, in order to be able to display Osc1/2 waveform at the UI. As there is no UI support for that yet, a gnuplot file will be written. The code needs to be explicitely enabled, as it dumps the files in the RT processor code. Signed-off-by: Stefan Westerfeld <[email protected]>
swesterfeld
force-pushed
the
blepsynth-plot
branch
from
6398ce9
to
4bc8680
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice if the oscillator wave form (which depends on the oscillator parameters) could be displayed at the UI. I've ported the necessary plotting code from Python (plotblep.py) to C++.
The actual waveform is sampled, so one parameter to tune might be how many samples to use. Or the overlap (copy_samples). Finally we currently don't have the infrastructure to display this, so when enabled, the wave forms of both oscillators are written to "/tmp/plot1" and "/tmp/plot2", just to be able to test it.