Add Goreleaser to build releases #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The generated windows binaries are yet to be verified. But it is ready for review and testing. Things to look for;
|
dehanj
commented
Apr 5, 2024
|
I have continued to verify:
Should we delete the "old" debian folder in this PR directly? Wont be used anymore. |
|
Windows binaries (including tray) checked on windows. |
|
Wrapped the pre-hook command in "sh -c " is the answer to make it run properly. Added a commit that fixes it. |
mchack-work
force-pushed
the
add_goreleaser
branch
4 times, most recently
from
0432a88
to
6b115a6
Compare
Since we now build .deb packages with goreleaser we remove the debian directory.
Let's use -buildvcs=false If the Git directory even has some untracked files the binary will be different with buildvcs tracking. This will probably shoot us in the foot again and again.
mchack-work
force-pushed
the
add_goreleaser
branch
from
6b115a6
to
ea8dc6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The files needed to build the packages I have put in the
system/folder. Some of these are duplicates from thedebianfolder, this is intentional since I think we can remove the ´Debian`folder going forward.The only noticeable difference between our "old" Debian package and these are that the
tkey-ssh-agent.1was gzip. It is not here.Needs to be verified: