fixed support for optimade, poscar and some cifs; error styles #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blokhin
approved these changes
Feb 29, 2024
nin-jin
reviewed
Feb 29, 2024
player/player.view.css
Outdated
There was a problem hiding this comment.
Тут лучше бы просто перехватывать ошибки и рисовать кастомное сообщение.
nin-jin
approved these changes
Feb 29, 2024
blokhin
approved these changes
Mar 1, 2024
nin-jin
reviewed
Mar 3, 2024
nin-jin
reviewed
Mar 3, 2024
nin-jin
reviewed
Mar 9, 2024
| \ | ||
| \display none | ||
| S \elements | ||
| ^ message_visible / <= Message $mol_view | ||
| sub / | ||
| <= Message_card $mol_card | ||
| title <= message? \ | ||
| theme \$mol_theme_special |
There was a problem hiding this comment.
я карточке поставил цвет фона $mol_theme.back, чтобы была непрозрачной, и тему special т.к. стандартная тема сливается с фоном, accent будет выглядеть как кнопка.
ну или можно на Message_card().Content() сделать цвет фона $mol_theme.card (а на Message_card - $mol_theme.back) и тогда уже без тем будет непрозрачной и не сливаться, (еще есть контейнер - Message, можно было бы сделать непрозрачным его, но с margin auto он теперь на всю ширину)
There was a problem hiding this comment.
А зачем вообще что-то показывать под сообщением? Мы же не смогли отрендерить ничего.
nin-jin
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.