Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix the race of TestRaftClusterMultipleRestart #8686

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Oct 10, 2024

What problem does this PR solve?

Issue Number: Close #8543.

What is changed and how does it work?

The details can be found in the issue.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2024
@rleungx rleungx requested a review from lhy1024 October 10, 2024 09:02
Copy link
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we Wait() here?

c.Unlock()

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.65%. Comparing base (48e72f1) to head (a439818).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8686      +/-   ##
==========================================
- Coverage   71.70%   71.65%   -0.06%     
==========================================
  Files         517      517              
  Lines       67450    67454       +4     
==========================================
- Hits        48364    48332      -32     
- Misses      15521    15550      +29     
- Partials     3565     3572       +7     
Flag Coverage Δ
unittests 71.65% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx
Copy link
Member Author

rleungx commented Oct 11, 2024

Should we Wait() here?

c.Unlock()

I don't want to change it only for the test. In general, the start and stop will be serial.

@rleungx rleungx requested a review from okJiang October 11, 2024 03:10
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 11, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 11, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-11 03:18:59.085640847 +0000 UTC m=+1188894.505853853: ☑️ agreed by okJiang.
  • 2024-10-11 03:31:21.747204022 +0000 UTC m=+1189637.167417034: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit 982fa22 into tikv:master Oct 11, 2024
24 of 25 checks passed
@rleungx rleungx deleted the fix-test-2024-30 branch October 11, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data race in TestRaftClusterMultipleRestart
3 participants