-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix the race of TestRaftClusterMultipleRestart
#8686
Conversation
Signed-off-by: Ryan Leung <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we Wait() here?
Line 752 in 48e72f1
c.Unlock() |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8686 +/- ##
==========================================
- Coverage 71.70% 71.65% -0.06%
==========================================
Files 517 517
Lines 67450 67454 +4
==========================================
- Hits 48364 48332 -32
- Misses 15521 15550 +29
- Partials 3565 3572 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
I don't want to change it only for the test. In general, the start and stop will be serial. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: Close #8543.
What is changed and how does it work?
The details can be found in the issue.
Check List
Tests
Release note