Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: Make tsoStream receives asynchronously #8483
client: Make tsoStream receives asynchronously #8483
Changes from 10 commits
140a7c2
88d9f5b
623d896
86d0f42
ff0f11a
ef47b9d
ff1d50d
9076c9d
39e4e0b
632781b
8809c45
ca64ed0
67967e4
1362aac
4699b41
7dbcd77
f4dc99a
1f2dcd8
123a869
2c6aaba
bff9eae
ef6e365
a9f4aee
388d705
a183aca
5314485
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 60 in client/tso_batch_controller.go
Codecov / codecov/patch
client/tso_batch_controller.go#L60
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assertion should be true in my understanding. Is it true? If so, I can change it to an assertion here.
The assignment statement in the next line exists before my change. If I understood it right, it didn't make much sense here, since if it's non-zero and we set it zero, it might mean that some requests will be dropped without notifying their caller and leave them waiting forever.
Check warning on line 125 in client/tso_batch_controller.go
Codecov / codecov/patch
client/tso_batch_controller.go#L125
Check warning on line 140 in client/tso_batch_controller.go
Codecov / codecov/patch
client/tso_batch_controller.go#L140