*: enable gocritic.exitAfterDefer

.golangci.yml

@@ -21,7 +21,6 @@ linters-settings:
     disabled-checks:
       - regexpMust
       - appendAssign
-      - exitAfterDefer
       - ifElseChain
   gosec:
     # To specify a set of rules to explicitly exclude.

client/pd_service_discovery_test.go

@@ -107,10 +107,10 @@ func newTestServer(isLeader bool) *testServer {
 func (s *testServer) run() {
 	lis, err := net.Listen("tcp", s.addr)
 	if err != nil {
-		log.Fatalf("failed to serve: %v", err)
+		log.Panicf("failed to serve: %v", err)
 	}
 	if err := s.grpcServer.Serve(lis); err != nil {
-		log.Fatalf("failed to serve: %v", err)
+		log.Panicf("failed to serve: %v", err)
 	}
 }
 

client/testutil/tempurl.go

@@ -37,19 +37,19 @@
 		}
 		time.Sleep(time.Second)
 	}
-	log.Fatal("failed to alloc test URL")
+	log.Panic("failed to alloc test URL")
 	return ""
 }
 
 func tryAllocTestURL() string {
 	l, err := net.Listen("tcp", "127.0.0.1:0")
 	if err != nil {
-		log.Fatal("listen failed", zap.Error(err))
+		log.Panic("listen failed", zap.Error(err))
 	}
 	addr := fmt.Sprintf("http://%s", l.Addr())
 	err = l.Close()
 	if err != nil {
-		log.Fatal("close failed", zap.Error(err))
+		log.Panic("close failed", zap.Error(err))
 	}
 
 	testAddrMutex.Lock()

client/tso_client.go

@@ -232,7 +232,7 @@
 func (c *tsoClient) GetTSOAllocatorClientConnByDCLocation(dcLocation string) (*grpc.ClientConn, string) {
 	url, ok := c.tsoAllocators.Load(dcLocation)
 	if !ok {
-		log.Fatal("[tso] the allocator leader should exist", zap.String("dc-location", dcLocation))
+		log.Panic("[tso] the allocator leader should exist", zap.String("dc-location", dcLocation))
 	}
 	cc, ok := c.svcDiscovery.GetClientConns().Load(url)
 	if !ok {

cmd/pd-server/main.go

@@ -232,7 +232,7 @@ func start(cmd *cobra.Command, args []string, services ...string) {
 	if err == nil {
 		log.ReplaceGlobals(cfg.Logger, cfg.LogProps)
 	} else {
-		log.Fatal("initialize logger error", errs.ZapError(err))
+		log.Panic("initialize logger error", errs.ZapError(err))
 	}
 	// Flushing any buffered log entries
 	defer log.Sync()
@@ -254,7 +254,7 @@ func start(cmd *cobra.Command, args []string, services ...string) {
 
 	err = join.PrepareJoinCluster(cfg)
 	if err != nil {
-		log.Fatal("join meet error", errs.ZapError(err))
+		log.Panic("join meet error", errs.ZapError(err))
 	}
 
 	// Creates server.
@@ -266,7 +266,7 @@ func start(cmd *cobra.Command, args []string, services ...string) {
 	serviceBuilders = append(serviceBuilders, dashboard.GetServiceBuilders()...)
 	svr, err := server.CreateServer(ctx, cfg, services, serviceBuilders...)
 	if err != nil {
-		log.Fatal("create server failed", errs.ZapError(err))
+		log.Panic("create server failed", errs.ZapError(err))
 	}
 
 	sc := make(chan os.Signal, 1)
@@ -283,7 +283,7 @@ func start(cmd *cobra.Command, args []string, services ...string) {
 	}()
 
 	if err := svr.Run(); err != nil {
-		log.Fatal("run server failed", errs.ZapError(err))
+		log.Panic("run server failed", errs.ZapError(err))
 	}
 
 	<-ctx.Done()

pkg/dashboard/distroutil/distro.go

@@ -33,7 +33,7 @@
 func MustGetResPath() string {
 	exePath, err := os.Executable()
 	if err != nil {
-		log.Fatal("failed to read the execution path", zap.Error(err))
+		log.Panic("failed to read the execution path", zap.Error(err))
 		return ""
 	}
 	return path.Join(path.Dir(exePath), resFolderName)
@@ -46,7 +46,7 @@
 	resPath := MustGetResPath()
 	strings, err := distro.ReadResourceStringsFromFile(path.Join(resPath, stringsFileName))
 	if err != nil {
-		log.Fatal("failed to load distro strings", zap.Error(err))
+		log.Panic("failed to load distro strings", zap.Error(err))
 	}
 	log.Info("using distribution strings", zap.Any("strings", strings))
 	distro.ReplaceGlobal(strings)

pkg/mcs/resourcemanager/server/server.go

@@ -394,7 +394,7 @@
 	if err == nil {
 		log.ReplaceGlobals(cfg.Logger, cfg.LogProps)
 	} else {
-		log.Fatal("initialize logger error", errs.ZapError(err))
+		log.Panic("initialize logger error", errs.ZapError(err))
 	}
 	// Flushing any buffered log entries
 	log.Sync()
@@ -421,7 +421,7 @@
 	}()
 
 	if err := svr.Run(); err != nil {
-		log.Fatal("run server failed", errs.ZapError(err))
+		log.Panic("run server failed", errs.ZapError(err))
 	}
 
 	<-ctx.Done()

pkg/mcs/scheduling/server/grpc_service.go

@@ -69,7 +69,7 @@
 func NewService[T ConfigProvider](svr bs.Server) registry.RegistrableService {
 	server, ok := svr.(*Server)
 	if !ok {
-		log.Fatal("create scheduling server failed")
+		log.Panic("create scheduling server failed")
 	}
 	return &Service{
 		Server: server,

pkg/mcs/scheduling/server/server.go

@@ -593,7 +593,7 @@
 	if err == nil {
 		log.ReplaceGlobals(cfg.Logger, cfg.LogProps)
 	} else {
-		log.Fatal("initialize logger error", errs.ZapError(err))
+		log.Panic("initialize logger error", errs.ZapError(err))
 	}
 	// Flushing any buffered log entries
 	log.Sync()
@@ -621,7 +621,7 @@
 	}()
 
 	if err := svr.Run(); err != nil {
-		log.Fatal("run server failed", errs.ZapError(err))
+		log.Panic("run server failed", errs.ZapError(err))
 	}
 
 	<-ctx.Done()

pkg/mcs/tso/server/grpc_service.go

@@ -65,7 +65,7 @@
 func NewService[T ConfigProvider](svr bs.Server) registry.RegistrableService {
 	server, ok := svr.(*Server)
 	if !ok {
-		log.Fatal("create tso server failed")
+		log.Panic("create tso server failed")
 	}
 	return &Service{
 		Server: server,

pkg/mcs/tso/server/server.go

@@ -465,7 +465,7 @@
 	if err == nil {
 		log.ReplaceGlobals(cfg.Logger, cfg.LogProps)
 	} else {
-		log.Fatal("initialize logger error", errs.ZapError(err))
+		log.Panic("initialize logger error", errs.ZapError(err))
 	}
 	// Flushing any buffered log entries
 	log.Sync()
@@ -493,7 +493,7 @@
 	}()
 
 	if err := svr.Run(); err != nil {
-		log.Fatal("run server failed", errs.ZapError(err))
+		log.Panic("run server failed", errs.ZapError(err))
 	}
 
 	<-ctx.Done()

pkg/mcs/utils/util.go

@@ -197,7 +197,7 @@
 	if s.IsClosed() {
 		log.Info("grpc server stopped")
 	} else {
-		log.Fatal("grpc server stopped unexpectedly", errs.ZapError(err))
+		log.Panic("grpc server stopped unexpectedly", errs.ZapError(err))
 	}
 }
 
@@ -210,7 +210,7 @@
 	if s.IsClosed() {
 		log.Info("http server stopped")
 	} else {
-		log.Fatal("http server stopped unexpectedly", errs.ZapError(err))
+		log.Panic("http server stopped unexpectedly", errs.ZapError(err))
 	}
 }
 
@@ -257,7 +257,7 @@
 		if s.IsClosed() {
 			log.Info("mux stopped serving", errs.ZapError(err))
 		} else {
-			log.Fatal("mux stopped serving unexpectedly", errs.ZapError(err))
+			log.Panic("mux stopped serving unexpectedly", errs.ZapError(err))
 		}
 	}
 }

pkg/member/member.go

@@ -341,7 +341,7 @@
 	data, err := leader.Marshal()
 	if err != nil {
 		// can't fail, so panic here.
-		log.Fatal("marshal pd leader meet error", zap.Stringer("pd-leader", leader), errs.ZapError(errs.ErrMarshalLeader, err))
+		log.Panic("marshal pd leader meet error", zap.Stringer("pd-leader", leader), errs.ZapError(errs.ErrMarshalLeader, err))
 	}
 	m.member = leader
 	m.memberValue = string(data)

pkg/member/participant.go

@@ -82,7 +82,7 @@
 	data, err := p.Marshal()
 	if err != nil {
 		// can't fail, so panic here.
-		log.Fatal("marshal leader meet error", zap.String("member-name", p.String()), errs.ZapError(errs.ErrMarshalLeader, err))
+		log.Panic("marshal leader meet error", zap.String("member-name", p.String()), errs.ZapError(errs.ErrMarshalLeader, err))
 	}
 	m.member = p
 	m.memberValue = string(data)

pkg/memory/meminfo.go

@@ -158,7 +158,7 @@
 
 func mustNil(err error) {
 	if err != nil {
-		log.Fatal("unexpected error", zap.Error(err), zap.Stack("stack"))
+		log.Panic("unexpected error", zap.Error(err), zap.Stack("stack"))
 	}
 }
 

pkg/schedule/coordinator.go

@@ -430,7 +430,7 @@
 		log.Error("cannot load schedulers' config", zap.Int("retry-times", i), errs.ZapError(err))
 	}
 	if err != nil {
-		log.Fatal("cannot load schedulers' config", errs.ZapError(err))
+		log.Panic("cannot load schedulers' config", errs.ZapError(err))
 	}
 	scheduleCfg := c.cluster.GetSchedulerConfig().GetScheduleConfig().Clone()
 	// The new way to create scheduler with the independent configuration.

pkg/schedule/schedulers/base_scheduler.go

@@ -53,7 +53,7 @@
 	case zeroGrowth:
 		return x
 	default:
-		log.Fatal("type error", errs.ZapError(errs.ErrInternalGrowth))
+		log.Panic("type error", errs.ZapError(errs.ErrInternalGrowth))
 	}
 	return 0
 }

pkg/schedule/schedulers/scheduler.go

@@ -120,7 +120,7 @@
 // func of a package.
 func RegisterScheduler(typ string, createFn CreateSchedulerFunc) {
 	if _, ok := schedulerMap[typ]; ok {
-		log.Fatal("duplicated scheduler", zap.String("type", typ), errs.ZapError(errs.ErrSchedulerDuplicated))
+		log.Panic("duplicated scheduler", zap.String("type", typ), errs.ZapError(errs.ErrSchedulerDuplicated))
 	}
 	schedulerMap[typ] = createFn
 }
@@ -129,7 +129,7 @@
 // func of package.
 func RegisterSliceDecoderBuilder(typ string, builder ConfigSliceDecoderBuilder) {
 	if _, ok := schedulerArgsToDecoder[typ]; ok {
-		log.Fatal("duplicated scheduler", zap.String("type", typ), errs.ZapError(errs.ErrSchedulerDuplicated))
+		log.Panic("duplicated scheduler", zap.String("type", typ), errs.ZapError(errs.ErrSchedulerDuplicated))
 	}
 	schedulerArgsToDecoder[typ] = builder
 	config.RegisterScheduler(typ)

pkg/storage/hot_region_storage_test.go

@@ -309,7 +309,7 @@ func newTestHotRegionStorage(pullInterval time.Duration,
 func PrintDirSize(path string) {
 	size, err := DirSizeB(path)
 	if err != nil {
-		log.Fatal(err)
+		log.Panic(err)
 	}
 	fmt.Printf("file size %d\n", size)
 }

pkg/syncer/history_buffer.go

@@ -148,7 +148,7 @@
 	if v != "" {
 		h.index, err = strconv.ParseUint(v, 10, 64)
 		if err != nil {
-			log.Fatal("load history index failed", errs.ZapError(errs.ErrStrconvParseUint, err))
+			log.Panic("load history index failed", errs.ZapError(errs.ErrStrconvParseUint, err))
 		}
 	}
 	log.Info("start from history index", zap.Uint64("start-index", h.firstIndex()))

pkg/tso/keyspace_group_manager.go

@@ -404,7 +404,7 @@
 	cfg ServiceConfig,
 ) *KeyspaceGroupManager {
 	if mcsutils.MaxKeyspaceGroupCountInUse > mcsutils.MaxKeyspaceGroupCount {
-		log.Fatal("MaxKeyspaceGroupCountInUse is larger than MaxKeyspaceGroupCount",
+		log.Panic("MaxKeyspaceGroupCountInUse is larger than MaxKeyspaceGroupCount",
 			zap.Uint32("max-keyspace-group-count-in-use", mcsutils.MaxKeyspaceGroupCountInUse),
 			zap.Uint32("max-keyspace-group-count", mcsutils.MaxKeyspaceGroupCount))
 	}

pkg/utils/logutil/log.go

@@ -90,7 +90,7 @@
 // Commonly used with a `defer`.
 func LogPanic() {
 	if e := recover(); e != nil {
-		log.Fatal("panic", zap.Reflect("recover", e))
+		log.Panic("panic", zap.Reflect("recover", e))
 	}
 }
 

pkg/utils/tempurl/tempurl.go

@@ -43,7 +43,7 @@
 		}
 		time.Sleep(time.Second)
 	}
-	log.Fatal("failed to alloc test URL")
+	log.Panic("failed to alloc test URL")
 	return ""
 }
 
@@ -53,12 +53,12 @@
 	}
 	l, err := net.Listen("tcp", "127.0.0.1:0")
 	if err != nil {
-		log.Fatal("listen failed", errs.ZapError(err))
+		log.Panic("listen failed", errs.ZapError(err))
 	}
 	addr := fmt.Sprintf("http://%s", l.Addr())
 	err = l.Close()
 	if err != nil {
-		log.Fatal("close failed", errs.ZapError(err))
+		log.Panic("close failed", errs.ZapError(err))
 	}
 
 	testAddrMutex.Lock()

pkg/versioninfo/feature.go

@@ -66,8 +66,8 @@
 func MinSupportedVersion(v Feature) *semver.Version {
 	target, ok := featuresDict[v]
 	if !ok {
-		log.Fatal("the corresponding version of the feature doesn't exist", zap.Int("feature-number", int(v)), errs.ZapError(errs.ErrFeatureNotExisted))
+		log.Panic("the corresponding version of the feature doesn't exist", zap.Int("feature-number", int(v)), errs.ZapError(errs.ErrFeatureNotExisted))
 	}
 	version := MustParseVersion(target)
 	return version
 }

pkg/versioninfo/versioninfo.go

@@ -67,7 +67,7 @@ func ParseVersion(v string) (*semver.Version, error) {
 func MustParseVersion(v string) *semver.Version {
 	ver, err := ParseVersion(v)
 	if err != nil {
-		log.Fatal("version string is illegal", errs.ZapError(err))
+		log.Panic("version string is illegal", errs.ZapError(err))
 	}
 	return ver
 }

server/cluster/cluster.go

@@ -421,7 +421,7 @@
 	defer tick.Stop()
 	totalMem, err := memory.MemTotal()
 	if err != nil {
-		log.Fatal("fail to get total memory:%s", zap.Error(err))
+		log.Panic("fail to get total memory:%s", zap.Error(err))
 	}
 	log.Info("memory info", zap.Uint64("total-mem", totalMem))
 	cfg := c.opt.GetPDServerConfig()

server/join/join.go

@@ -95,7 +95,7 @@
 	if _, err := os.Stat(filePath); !os.IsNotExist(err) {
 		s, err := os.ReadFile(filePath)
 		if err != nil {
-			log.Fatal("read the join config meet error", errs.ZapError(errs.ErrIORead, err))
+			log.Panic("read the join config meet error", errs.ZapError(errs.ErrIORead, err))
 		}
 		cfg.InitialCluster = strings.TrimSpace(string(s))
 		cfg.InitialClusterState = embed.ClusterStateFlagExisting

tools/pd-analysis/analysis/parse_log.go

@@ -130,10 +130,10 @@
 	if pattern, ok := supportLayouts[layout]; ok {
 		r, err = regexp.Compile(pattern)
 		if err != nil {
-			log.Fatal(err)
+			log.Panic(err)
 		}
 	} else {
-		log.Fatal("unsupported time layout")
+		log.Panic("unsupported time layout")
 	}
 	return func(content string) (time.Time, error) {
 		result := r.FindStringSubmatch(content)