Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/realcluster: using real pd with race #8270

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Jun 7, 2024

What problem does this PR solve?

Issue Number: Ref #7298

What is changed and how does it work?

running with data race

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: husharp <[email protected]>
Copy link
Contributor

ti-chi-bot bot commented Jun 7, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/needs-triage-completed labels Jun 7, 2024
@HuSharp HuSharp requested a review from lhy1024 June 7, 2024 04:44
@ti-chi-bot ti-chi-bot bot requested a review from nolouch June 7, 2024 04:44
@HuSharp
Copy link
Member Author

HuSharp commented Jun 7, 2024

/test ?

Copy link
Contributor

ti-chi-bot bot commented Jun 7, 2024

@HuSharp: The following commands are available to trigger required jobs:

  • /test build

The following commands are available to trigger optional jobs:

  • /test pull-integration-copr-test
  • /test pull-integration-realcluster-test

Use /test all to run the following jobs that were automatically triggered:

  • tikv/pd/ghpr_build

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 7, 2024
@HuSharp
Copy link
Member Author

HuSharp commented Jun 7, 2024

/test pull-integration-realcluster-test

@ti-chi-bot ti-chi-bot bot added status/LGT1 Indicates that a PR has LGTM 1. and removed do-not-merge/needs-triage-completed labels Jun 7, 2024
@HuSharp
Copy link
Member Author

HuSharp commented Jun 7, 2024

Ref #8263, #8267

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.33%. Comparing base (494c0e9) to head (2be4512).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8270      +/-   ##
==========================================
+ Coverage   77.30%   77.33%   +0.02%     
==========================================
  Files         471      471              
  Lines       61380    61380              
==========================================
+ Hits        47451    47466      +15     
+ Misses      10373    10366       -7     
+ Partials     3556     3548       -8     
Flag Coverage Δ
unittests 77.33% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@HuSharp HuSharp added the require-LGT1 Indicates that the PR requires an LGTM. label Jun 7, 2024
@HuSharp
Copy link
Member Author

HuSharp commented Jun 7, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jun 7, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jun 7, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 2be4512

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 7, 2024
@ti-chi-bot ti-chi-bot bot merged commit f69d600 into tikv:master Jun 7, 2024
22 checks passed
@HuSharp HuSharp deleted the real_clister_with_race branch June 7, 2024 04:54
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jun 17, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #8295.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8296.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 17, 2024
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 17, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8297.

@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants