tools/ctl: add caller ID for pd-ctl
#8214
Conversation
Signed-off-by: husharp <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
the
release-note-none
HuSharp
requested review from
JmPotato
and removed request for
nolouch and
rleungx
ti-chi-bot
bot
added
the
size/M
|
@okJiang PTAL, thx! |
| func TestSendAndGetComponent(t *testing.T) { | ||
| re := require.New(t) | ||
| handler := func(context.Context, *server.Server) (http.Handler, apiutil.APIServiceGroup, error) { | ||
| mux := http.NewServeMux() | ||
| mux.HandleFunc("/pd/api/v1/cluster", func(w http.ResponseWriter, r *http.Request) { |
There was a problem hiding this comment.
For now, only cluster command was replaced by PD HTTP SDK
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8214 +/- ##
==========================================
+ Coverage 77.29% 77.34% +0.05%
==========================================
Files 471 471
Lines 61445 61445
==========================================
+ Hits 47491 47527 +36
+ Misses 10395 10350 -45
- Partials 3559 3568 +9
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@okJiang: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: husharp <[email protected]>
|
/merge |
|
@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 4daa1a7
|
ti-chi-bot
bot
added
the
status/can-merge
|
/merge |
|
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: Ref #7300
What is changed and how does it work?
After replacing HTTP with SDK #7490, we need to add the
calledIDexplicitly to keep consistent with #4491And source ID can be consistent with caller ID, #7565
Check List
Tests
Release note